Acceptance criteria
Checklists
No modifier classes removed
General
Unit tests
Sass/Emotion conversion process
CSS tech debt
DOM Cleanup
[ ] Did NOT remove any block/element classNames (e.g. euiComponent, euiComponent__child) deleted .euiDataGridHeaderCell__content div wrapper from header control cells
[ ] SEARCH KIBANA FIRST: Deleted any modifier classNames or maps if not being used in Kibana. - none deleted
Kibana due diligence
Extras/nice-to-have
Acceptance criteria
[ ] Breaking changes are identified and broadcast to consumers[ ] Any dependent components are identified in a new issueChecklists
No modifier classes removed
General
className(s)read as expected in snapshots and browsers- [ ] Checked component playgroundUnit tests
shouldRenderCustomStyles()test was added and passes with parent component and any nestedchildProps(e.g.tooltipProps)mount()ed snapshots in favor ofrender()or a more specific assertionSass/Emotion conversion process
$euiSizetoeuiTheme.size.base)to exported JS versionssrc/components/index.scsssrc/amsterdam/overrides/{component}.scssfiles (styles within should have been converted to the baseline Emotion styles)[ ] Ranyarn compile-scssto update var/mixin JSON files[ ] Simplifiedcalc()tomathWithUnitsif possible (if mixing different unit types, this may not be possible)[ ] Added an@warndeprecation message within theglobal_styling/mixins/{component}.scssfileCSS tech debt
euiCanAnimategapproperty to add margin between items if using flex-inlineand-blocklogical properties (check inline styles as well as CSS)DOM Cleanup
[ ] Did NOT remove any block/element classNames (e.g.deletedeuiComponent,euiComponent__child).euiDataGridHeaderCell__contentdiv wrapper from header control cells[ ] SEARCH KIBANA FIRST: Deleted any modifier classNames or maps if not being used in Kibana.- none deletedKibana due diligence
**/target, **/*.snap, **/*.storyshotfor less noise) foreui{Component}(case sensitive) to find:euiBadgeclass on a div instead of simply using theEuiBadgecomponent)Extras/nice-to-have
[ ] Documentation pass:[ ] Check for issues in the backlog that could be a quick fix for that component[ ] Optional component/code cleanup: consider splitting up the component into multiple children if it's overly verbose or difficult to reason about