Will take a look into fixing this shortly!

As a heads up, I also chatted with @kertal when he pinged me about this issue and I just wanted to raise another possible edge case related to consumers/developers updating the rowHeightsOptions prop & not receiving an expected display selector update.

The fix for this will address the following scenario:

The data grid initializes with an undefined default row height
The user has not yet interacted with the row height switcher in any way
The consumer/developer sets row height to auto via props
Outcome: The datagrid should show an updated row height of auto in the display selector

The fix for this will not address the following scenario:

The data grid initializes with an undefined default row height
The user sets row height to a line count of 2 in the UI controls
The consumer/developer sets row height to auto via props
Outcome: Step 3 is ignored, and the datagrid will still show a row height of line count. User settings will always override consumer settings (note that this is also how the density control behaves and has previously behaved)

@kertal described this latter behavior as not what their app wants, which would need discussion from UX/our team IMO, because it's a deviation from the current intentional UX. I also suggested a possible workaround of completely remounting the data grid (which would clear user settings), since he also incidentally described their desired behavior as being tied to page/URL state.

[EuiDataGrid] Row height options props update doesn't work #5524

Description

Summary

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions