Skip to content

EUICodeEditor doesn't prevent focus trap via hint overlay if you've made edits #3819

@poffdeluxe

Description

@poffdeluxe

I was trying out the EUICodeEditor on the demo page and noticed that when I hit escape before making edits, I get the "When you're done press, press Escape to stop editing" overlay on the editor. But after making edits, hitting escape doesn't seem to do anything.

Repro steps

  1. Load up https://elastic.github.io/eui/#/forms/code-editor and put focus on the editor
  2. Hit escape (should bring up overlay)
  3. Click on the overlay to return focus and type whatever you want
  4. Try to hit escape again

Expected Behavior
The hint overlay appears

Actual Behavior
Focus stays on the editor and nothing happens

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions