Skip to content

[EuiToken] aria-label gets applied to span because of {...rest} #3182

@myasonik

Description

@myasonik

Because of where the {...rest} is, when passing in an aria-label it gets applied to a span where aria-label (and most other aria-* properties) don't work...

3 possible solutions I see (not sure which is best):

  • move the ...rest to the EuiIcon inside the span
  • check for aria-* props and put those on EuiIcon manually (could be later reused in other components potentially)
  • add a iconProps property which is essentially a second ...rest put on EuiIcon

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions