Skip to content

<KuiButton> needs submit prop #3

@bevacqua

Description

@bevacqua

We're shadowing type='submit' for <button> because type is used to declare primary, secondary, and so on.

<button
disabled={isDisabled}
className={classes}
{...rest}

We should either rename type to something else such as hue='danger', or add a submit prop that results in <button type='submit'>.

Both approaches have their pros and cons. type fits the button "roles" very well, role would also clash with aria props, etc. At the same time, submit={ Boolean } wouldn't fix support for <button type='button'> either.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions