Critical (imo):
Less so:
Up for debate:
1. I think the focus order would be better in visual order. I get the argument that it's to keep users from having to tab through all the options, then hit "expand", then potentially go back to the option they want but I think it's so unexpected that it's difficult to find and you lose your place instead of it feeling smooth. I tried playing around with a super obvious focus state and that grabbed my attention enough that I knew what was going on but that'd be pretty far away from our current focus state styles.
2. I think EUI should provide a skip link past the navigation.
Critical (imo):
EuiNavDrawera11y, pt. 1 #2643)navelement (covered by Improve a11y in EuiNavDrawer #2417)EuiNavDrawerfocus management, flyout auto-close #2749)EuiNavDrawerfocus management, flyout auto-close #2749)Less so:
aria-pressed=true|falsedefined on them to communicate their state.aria-pressed=true|falsedefined to communicate state. This can replace therole=switchandaria-checked=true|false.(EuiNavDrawera11y, pt. 1 #2643)Up for debate:
1. I think the focus order would be better in visual order. I get the argument that it's to keep users from having to tab through all the options, then hit "expand", then potentially go back to the option they want but I think it's so unexpected that it's difficult to find and you lose your place instead of it feeling smooth. I tried playing around with a super obvious focus state and that grabbed my attention enough that I knew what was going on but that'd be pretty far away from our current focus state styles.2. I think EUI should provide a skip link past the navigation.