Skip to content

eui.d.ts has undeclared dependency imports #1959

@thompsongl

Description

@thompsongl

Type checking in elastic/gatsby-eui-starter#7 finds that @types/react-virtualized and @types/enzyme are imported in eui.d.ts but not declared in its dependencies or peerDependencies (gatsby-eui-starter uses neither).

@types/react-virtualized seems like it should simply move to dependencies as it's used directly in src.
I'm less certain about what to do with the exposed enzyme test helpers.

Kibana covers these holes because it uses both libraries.
Cloud uses enzyme and specifiesstrict: false in its tsconfig and so gets past the react-virutalized warning.

I'll get thoughts from @chandlerprall before moving forward with anything.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions