Skip to content

EuiBasicTable header names should be node propType #1002

@sorenlouv

Description

@sorenlouv

With KUI Tables it was possible to add tooltips to the header cells. This is useful since some columns need to be explained to the user. In APM we have a column called "Impact" with a tooltip saying: Impact shows the most used and slowest endpoints in your service.
screen shot 2018-06-29 at 17 09 11

Implementation

Edit: Option A was selected as the best solution of the two.

Option A) EuiBasicTable currently only support strings as name. By allowing custom elements, it would be possible to customize the header in a very flexible way:

{
  field: 'impact',
  name: (
    <div>Impact <EuiToolTip content="Help text"/></div>
  ),
  sortable: true,
  dataType: 'number'
}

Option B) Another option is to keep the name field limited to strings, but introduce a tooltip field:

{
  field: 'impact',
  name: 'Impact',
  tooltip: 'Impact shows the most used and slowest endpoints in your service.',
  sortable: true,
  dataType: 'number'
}

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions