Rename .euiDataGridRowCell__expandButton to .euiDataGridRowCell__expandActions

cee-chen · cee-chen · commit dc95fe9ca42c · 2022-02-02T13:29:07.000-08:00
diff --git a/src/components/datagrid/_data_grid_data_row.scss b/src/components/datagrid/_data_grid_data_row.scss
@@ -159,9 +159,7 @@
 }
 
 // Cell actions
-// Could probably be more precisely named than '__expandButton', since there can be multiple actions/buttons
-// TODO: Consider renaming this when working on https://github.com/elastic/eui/issues/5132
-.euiDataGridRowCell__expandButton {
+.euiDataGridRowCell__expandActions {
   display: flex;
 }
 @include euiDataGridRowCellActions($definedHeight: false) {
diff --git a/src/components/datagrid/_mixins.scss b/src/components/datagrid/_mixins.scss
@@ -87,12 +87,12 @@ $euiDataGridStyles: (
   @if $definedHeight {
     // Defined heights are cells with row heights of auto, lineCount, or a static height
     // that set the __contentByHeight class
-    .euiDataGridRowCell__contentByHeight + .euiDataGridRowCell__expandButton {
+    .euiDataGridRowCell__contentByHeight + .euiDataGridRowCell__expandActions {
       @content;
     }
   } @else {
     // Otherwise, an undefined height (single flex row) will set __expandContent
-    .euiDataGridRowCell__expandContent + .euiDataGridRowCell__expandButton {
+    .euiDataGridRowCell__expandContent + .euiDataGridRowCell__expandActions {
       @content;
     }
   }
diff --git a/src/components/datagrid/body/data_grid_cell_actions.test.tsx b/src/components/datagrid/body/data_grid_cell_actions.test.tsx
@@ -28,7 +28,7 @@ describe('EuiDataGridCellActions', () => {
 
     expect(component).toMatchInlineSnapshot(`
       <div
-        className="euiDataGridRowCell__expandButton"
+        className="euiDataGridRowCell__expandActions"
       >
         <EuiI18n
           default="Click or hit enter to interact with cell content"
@@ -65,7 +65,7 @@ describe('EuiDataGridCellActions', () => {
 
     expect(component).toMatchInlineSnapshot(`
       <div
-        className="euiDataGridRowCell__expandButton"
+        className="euiDataGridRowCell__expandActions"
       >
         <Component
           Component={[Function]}
diff --git a/src/components/datagrid/body/data_grid_cell_actions.tsx b/src/components/datagrid/body/data_grid_cell_actions.tsx
@@ -38,7 +38,7 @@ export const EuiDataGridCellActions = ({
   const buttonIconClasses = classNames('euiDataGridRowCell__expandButtonIcon', {
     'euiDataGridRowCell__expandButtonIcon-isActive': popoverIsOpen,
   });
-  const buttonClasses = classNames('euiDataGridRowCell__expandButton', {
+  const buttonClasses = classNames('euiDataGridRowCell__expandActions', {
     'euiDataGridRowCell__expandButton-isActive': popoverIsOpen,
   });
   const expandButton = (

Original file line number	Diff line number	Diff line change
`@@ -159,9 +159,7 @@`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`// Cell actions`
`162`		`-// Could probably be more precisely named than '__expandButton', since there can be multiple actions/buttons`
`163`		`-// TODO: Consider renaming this when working on https://github.com/elastic/eui/issues/5132`
`164`		`-.euiDataGridRowCell__expandButton {`
	`162`	`+.euiDataGridRowCell__expandActions {`
`165`	`163`	`display: flex;`
`166`	`164`	`}`
`167`	`165`	`@include euiDataGridRowCellActions($definedHeight: false) {`
Original file line number	Diff line number	Diff line change
`@@ -87,12 +87,12 @@ $euiDataGridStyles: (`
`87`	`87`	`@if $definedHeight {`
`88`	`88`	`// Defined heights are cells with row heights of auto, lineCount, or a static height`
`89`	`89`	`// that set the __contentByHeight class`
`90`		`- .euiDataGridRowCell__contentByHeight + .euiDataGridRowCell__expandButton {`
	`90`	`+ .euiDataGridRowCell__contentByHeight + .euiDataGridRowCell__expandActions {`
`91`	`91`	`@content;`
`92`	`92`	`}`
`93`	`93`	`} @else {`
`94`	`94`	`// Otherwise, an undefined height (single flex row) will set __expandContent`
`95`		`- .euiDataGridRowCell__expandContent + .euiDataGridRowCell__expandButton {`
	`95`	`+ .euiDataGridRowCell__expandContent + .euiDataGridRowCell__expandActions {`
`96`	`96`	`@content;`
`97`	`97`	`}`
`98`	`98`	`}`