Skip to content

Commit c7e35b0

Browse files
committed
[PR feedback] Standardize hue/saturation indicator focus outline on light & dark modes
1 parent 9331f5a commit c7e35b0

4 files changed

Lines changed: 5 additions & 8 deletions

File tree

71 Bytes
Loading
-144 Bytes
Loading

packages/eui/src/components/color_picker/hue.styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export const euiHueStyles = (euiThemeContext: UseEuiTheme) => {
9898
? `
9999
&:focus {
100100
${euiRangeThumbPerBrowser(`
101-
outline: ${euiTheme.border.width.thin} solid ${euiTheme.colors.fullShade};
101+
outline: ${euiTheme.border.width.thin} solid ${euiTheme.colors.ink};
102102
outline-offset: 0;
103103
`)}
104104
}`

packages/eui/src/components/color_picker/saturation.styles.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ export const euiSaturationStyles = (euiThemeContext: UseEuiTheme) => {
3939
4040
.euiSaturation__indicator {
4141
${highContrastMode
42-
? `outline: ${euiTheme.border.thin};`
42+
? `
43+
outline: ${euiTheme.border.width.thin} solid ${euiTheme.colors.ink};
44+
outline-offset: 0;`
4345
: `
4446
outline: none; /* Standardize indicator focus ring */
4547
box-shadow: 0 0 0 ${euiTheme.focus.width} ${euiTheme.colors.primary};
@@ -90,12 +92,7 @@ export const euiSaturationStyles = (euiThemeContext: UseEuiTheme) => {
9092
${highContrastMode
9193
? `
9294
border: ${euiTheme.border.width.thick} solid ${euiTheme.colors.ink};
93-
background-color: ${euiTheme.colors.ghost};
94-
95-
&:focus-visible {
96-
outline: ${euiTheme.border.thin};
97-
outline-offset: 0;
98-
}`
95+
background-color: ${euiTheme.colors.ghost};`
9996
: `
10097
border: ${euiTheme.border.width.thin} solid ${euiTheme.colors.darkestShade};
10198

0 commit comments

Comments
 (0)