Skip to content

Commit c5343af

Browse files
committed
🔥 Remove Safari animation workaround now that Safari 17 is out
1 parent 6f3a1e8 commit c5343af

1 file changed

Lines changed: 0 additions & 27 deletions

File tree

‎src/components/datagrid/_data_grid_data_row.scss‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,6 @@
3838
animation-delay: $euiAnimSpeedNormal;
3939
animation-fill-mode: forwards;
4040
}
41-
/*
42-
* For some incredibly bizarre reason, Safari doesn't correctly update the flex
43-
* width of the content (when rows are an undefined height/single flex row),
44-
* which causes the action icons to overlap & makes the content less readable.
45-
* This workaround "animation" forces a rerender of the flex content width
46-
*
47-
* TODO: Remove this workaround once https://bugs.webkit.org/show_bug.cgi?id=258539 is resolved
48-
*/
49-
.euiDataGridRowCell__defaultHeight .euiDataGridRowCell__content {
50-
animation-name: euiDataGridCellActionsSafariWorkaround;
51-
animation-duration: 1000ms; // I don't know why the duration matters or why it being longer works more consistently 🥲
52-
animation-delay: $euiAnimSpeedNormal + $euiAnimSpeedExtraFast; // Wait for above animation to finish
53-
animation-iteration-count: 1;
54-
animation-fill-mode: forwards;
55-
animation-timing-function: linear;
56-
}
5741
}
5842

5943
// On focus, directly show action buttons (without animation)
@@ -255,14 +239,3 @@
255239
width: $euiSizeM;
256240
}
257241
}
258-
@keyframes euiDataGridCellActionsSafariWorkaround {
259-
from {
260-
width: 100%;
261-
flex-basis: 100%;
262-
}
263-
264-
to {
265-
width: auto;
266-
flex-basis: auto;
267-
}
268-
}

0 commit comments

Comments
 (0)