Skip to content

Commit 8c72ddd

Browse files
committed
[docs] Fix EuiDataGrid not correctiny loading pagination @defaults
1 parent 22964d2 commit 8c72ddd

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

src-docs/src/views/datagrid/advanced/datagrid_memory_example.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ const inMemorySortingDataGridSource = require('!!raw-loader!./in_memory_sorting'
2323

2424
import {
2525
EuiDataGridColumn,
26-
EuiDataGridPaginationProps,
2726
EuiDataGridSorting,
2827
EuiDataGridInMemory,
2928
EuiDataGridStyle,
@@ -32,6 +31,7 @@ import {
3231
EuiDataGridCellValueElementProps,
3332
EuiDataGridSchemaDetector,
3433
} from '!!prop-loader!../../../../../src/components/datagrid/data_grid_types';
34+
import { EuiDataGridPaginationProps } from '../basics/_props';
3535

3636
export const DataGridMemoryExample = {
3737
sections: [

src-docs/src/views/datagrid/basics/_props.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
import React from 'react';
2-
import { EuiDataGrid } from '../../../../../src/components';
1+
import React, { FunctionComponent } from 'react';
2+
import {
3+
EuiDataGrid,
4+
EuiDataGridPaginationProps as _EuiDataGridPaginationProps,
5+
} from '../../../../../src/components';
36

47
import { DataGridPropsTable } from '../_props_table';
58
import { gridSnippets } from '../_snippets';
@@ -41,3 +44,8 @@ export const DataGridTopProps = () => {
4144
/>
4245
);
4346
};
47+
48+
// Loading `EuiDataGridPaginationProps` via !prop-loader doesn't correctly inherit @defaults
49+
export const EuiDataGridPaginationProps: FunctionComponent<
50+
_EuiDataGridPaginationProps
51+
> = () => <div />;

src-docs/src/views/datagrid/basics/datagrid_example.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
} from '../../../../../src/components';
1313

1414
import DataGrid from './datagrid';
15-
import { DataGridTopProps } from './_props';
15+
import { DataGridTopProps, EuiDataGridPaginationProps } from './_props';
1616
const dataGridSource = require('!!raw-loader!./datagrid');
1717

1818
import DataGridContainer from './container';
@@ -28,7 +28,6 @@ const dataGridVirtualizationConstrainedSource = require('!!raw-loader!./virtuali
2828
import {
2929
EuiDataGridColumn,
3030
EuiDataGridColumnCellAction,
31-
EuiDataGridPaginationProps,
3231
EuiDataGridSorting,
3332
EuiDataGridInMemory,
3433
EuiDataGridStyle,

0 commit comments

Comments
 (0)