🔥 Update downstream props/types

cee-chen · cee-chen · commit 882611b78e92 · 2023-11-05T15:55:58.000-08:00
diff --git a/src/components/collapsible_nav_beta/collapsible_nav_beta.stories.tsx b/src/components/collapsible_nav_beta/collapsible_nav_beta.stories.tsx
@@ -331,7 +331,6 @@ export const SecurityExample: Story = {
             { title: 'Intelligence', href: '#' },
             {
               title: 'Explore',
-              href: '#',
               items: [
                 { title: 'Host', href: '#' },
                 { title: 'Users', href: '#', isSelected: true },
@@ -342,7 +341,6 @@ export const SecurityExample: Story = {
             { title: 'Assets', href: '#' },
             {
               title: 'Rules',
-              href: '#',
               items: [
                 { title: 'SIEM rules', href: '#' },
                 { title: 'Shared exception list', href: '#' },
@@ -352,7 +350,6 @@ export const SecurityExample: Story = {
             },
             {
               title: 'Machine learning',
-              href: '#',
               items: [
                 { title: 'Overview', href: '#' },
                 { title: 'Notifications', href: '#' },
@@ -364,7 +361,6 @@ export const SecurityExample: Story = {
             },
             {
               title: 'Settings',
-              href: '#',
               items: [
                 { title: 'Endpoints', href: '#' },
                 { title: 'OS query', href: '#' },
diff --git a/src/components/collapsible_nav_beta/collapsible_nav_group/collapsible_nav_group.stories.tsx b/src/components/collapsible_nav_beta/collapsible_nav_group/collapsible_nav_group.stories.tsx
@@ -87,7 +87,4 @@ export const EdgeCaseTesting: Story = {
       <EuiCollapsibleNavBeta.Group {...args} />
     </CollapsibleNavTemplate>
   ),
-  args: {
-    href: '#',
-  },
 };
diff --git a/src/components/collapsible_nav_beta/collapsible_nav_group/collapsible_nav_group.tsx b/src/components/collapsible_nav_beta/collapsible_nav_group/collapsible_nav_group.tsx
@@ -16,29 +16,24 @@ import { EuiCollapsibleNavContext } from '../context';
 import {
   EuiCollapsibleNavItem,
   EuiCollapsibleNavSubItems,
-  EuiCollapsibleNavSubItemProps,
-  EuiCollapsibleNavItemProps,
+  type EuiCollapsibleNavItemProps,
+  type _SharedEuiCollapsibleNavItemProps,
 } from '../collapsible_nav_item/collapsible_nav_item';
 import { EuiCollapsedNavPopover } from '../collapsible_nav_item/collapsed/collapsed_nav_popover';
 
 import { euiCollapsibleNavGroupStyles } from './collapsible_nav_group.styles';
 
-export type EuiCollapsibleNavGroupProps = Omit<
-  EuiCollapsibleNavItemProps,
-  'items' | 'accordionProps'
-> & {
-  /**
-   * Will render an array of `EuiCollapsibleNavItems`.
-   *
-   * Accepts any #EuiCollapsibleNavItemProps. Or, to render completely custom
-   * subitem content, pass an object with a `renderItem` callback.
-   */
-  items: EuiCollapsibleNavSubItemProps[];
-  /**
-   * Optional props to pass to the wrapping div
-   */
-  wrapperProps?: HTMLAttributes<HTMLDivElement> & CommonProps;
-};
+export type EuiCollapsibleNavGroupProps = _SharedEuiCollapsibleNavItemProps &
+  Pick<
+    EuiCollapsibleNavItemProps,
+    'title' | 'titleElement' | 'icon' | 'iconProps'
+  > &
+  Required<Pick<EuiCollapsibleNavItemProps, 'items'>> & {
+    /**
+     * Optional props to pass to the wrapping div
+     */
+    wrapperProps?: HTMLAttributes<HTMLDivElement> & CommonProps;
+  };
 
 /**
  * This component should only ever be used as a **top-level component**, and not as a sub-item.
