Clean up/remove various responsive Sass files/modifiers

cee-chen · cee-chen · commit 4bf8c22e2db2 · 2024-03-26T12:32:02.000-07:00
+ remove `.euiTableRowCell--isMobileHeader` - isn't used anywhere that I can tell 🤷
diff --git a/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap b/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
@@ -8,7 +8,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >
@@ -122,7 +122,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >
diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
@@ -104,7 +104,7 @@ exports[`EuiInMemoryTable empty array 1`] = `
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >
@@ -199,7 +199,7 @@ exports[`EuiInMemoryTable with items 1`] = `
 >
   <div>
     <table
-      class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"
+      class="euiTable emotion-euiTable-fixed-uncompressed-desktop"
       id="__table_generated-id"
       tabindex="-1"
     >
diff --git a/src/components/table/__snapshots__/table.test.tsx.snap b/src/components/table/__snapshots__/table.test.tsx.snap
@@ -3,7 +3,7 @@
 exports[`renders EuiTable 1`] = `
 <table
   aria-label="aria-label"
-  class="euiTable testClass1 testClass2 euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop-euiTestCss"
+  class="euiTable testClass1 testClass2 emotion-euiTable-fixed-uncompressed-desktop-euiTestCss"
   data-test-subj="test subject string"
   tabindex="-1"
 >
diff --git a/src/components/table/_index.scss b/src/components/table/_index.scss
@@ -2,6 +2,3 @@
 @import 'mixins';
 
 @import 'table';
-@import 'responsive';
-
-@import 'mobile/index';
diff --git a/src/components/table/_responsive.scss b/src/components/table/_responsive.scss
diff --git a/src/components/table/_table.scss b/src/components/table/_table.scss
@@ -71,10 +71,6 @@
   &--baseline {
     vertical-align: baseline;
   }
-
-  &.euiTableRowCell--isMobileHeader {
-    display: none; // Hide if not mobile breakpoint
-  }
 }
 
 .euiTableRowCellCheckbox {
diff --git a/src/components/table/mobile/_index.scss b/src/components/table/mobile/_index.scss
diff --git a/src/components/table/mobile/_mobile.scss b/src/components/table/mobile/_mobile.scss
diff --git a/src/components/table/table.tsx b/src/components/table/table.tsx
@@ -36,9 +36,7 @@ export const EuiTable: FunctionComponent<EuiTableProps> = ({
   // TODO: Make the table responsive breakpoint customizable via prop
   const isResponsive = useIsWithinMaxBreakpoint('s') && responsive;
 
-  const classes = classNames('euiTable', className, {
-    'euiTable--responsive': responsive,
-  });
+  const classes = classNames('euiTable', className);
 
   const styles = useEuiMemoizedStyles(euiTableStyles);
   const cssStyles = [

Original file line number	Diff line number	Diff line change
@@ -8,7 +8,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = `
`8`	`8`	`>`
`9`	`9`	`<div>`
`10`	`10`	`<table`
`11`		`- class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"`
	`11`	`+ class="euiTable emotion-euiTable-fixed-uncompressed-desktop"`
`12`	`12`	`id="__table_generated-id"`
`13`	`13`	`tabindex="-1"`
`14`	`14`	`>`
@@ -122,7 +122,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
`122`	`122`	`>`
`123`	`123`	`<div>`
`124`	`124`	`<table`
`125`		`- class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"`
	`125`	`+ class="euiTable emotion-euiTable-fixed-uncompressed-desktop"`
`126`	`126`	`id="__table_generated-id"`
`127`	`127`	`tabindex="-1"`
`128`	`128`	`>`
Original file line number	Diff line number	Diff line change
@@ -104,7 +104,7 @@ exports[`EuiInMemoryTable empty array 1`] = `
`104`	`104`	`>`
`105`	`105`	`<div>`
`106`	`106`	`<table`
`107`		`- class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"`
	`107`	`+ class="euiTable emotion-euiTable-fixed-uncompressed-desktop"`
`108`	`108`	`id="__table_generated-id"`
`109`	`109`	`tabindex="-1"`
`110`	`110`	`>`
@@ -199,7 +199,7 @@ exports[`EuiInMemoryTable with items 1`] = `
`199`	`199`	`>`
`200`	`200`	`<div>`
`201`	`201`	`<table`
`202`		`- class="euiTable euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop"`
	`202`	`+ class="euiTable emotion-euiTable-fixed-uncompressed-desktop"`
`203`	`203`	`id="__table_generated-id"`
`204`	`204`	`tabindex="-1"`
`205`	`205`	`>`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	exports[`renders EuiTable 1`] = `
`4`	`4`	`<table`
`5`	`5`	`aria-label="aria-label"`
`6`		`- class="euiTable testClass1 testClass2 euiTable--responsive emotion-euiTable-fixed-uncompressed-desktop-euiTestCss"`
	`6`	`+ class="euiTable testClass1 testClass2 emotion-euiTable-fixed-uncompressed-desktop-euiTestCss"`
`7`	`7`	`data-test-subj="test subject string"`
`8`	`8`	`tabindex="-1"`
`9`	`9`	`>`
Original file line number	Diff line number	Diff line change
`@@ -71,10 +71,6 @@`
`71`	`71`	`&--baseline {`
`72`	`72`	`vertical-align: baseline;`
`73`	`73`	`}`
`74`		`-`
`75`		`- &.euiTableRowCell--isMobileHeader {`
`76`		`- display: none; // Hide if not mobile breakpoint`
`77`		`- }`
`78`	`74`	`}`
`79`	`75`
`80`	`76`	`.euiTableRowCellCheckbox {`