[opinionated refactor] Convert EuiSelectableListItem from a class component to a function component

cee-chen · cee-chen · commit 48515874d222 · 2024-05-07T17:28:15.000-07:00
- not sure if this is too extra, I found this easier to grok personally. If it feels too much for this PR, we can revert it or pull it out to a separate PR
diff --git a/src/components/selectable/selectable_list/__snapshots__/selectable_list_item.test.tsx.snap b/src/components/selectable/selectable_list/__snapshots__/selectable_list_item.test.tsx.snap
@@ -514,7 +514,7 @@ exports[`EuiSelectableListItem props tooltip behavior on mouseover 1`] = `
   <div>
     <li
       aria-checked="false"
-      aria-describedby=""
+      aria-describedby="generated-id"
       class="euiSelectableListItem euiSelectableListItem--paddingSmall"
       role="option"
     >
@@ -574,7 +574,7 @@ exports[`EuiSelectableListItem props tooltip behavior when isFocused 1`] = `
   <div>
     <li
       aria-checked="false"
-      aria-describedby=""
+      aria-describedby="generated-id"
       aria-selected="true"
       class="euiSelectableListItem euiSelectableListItem-isFocused euiSelectableListItem--paddingSmall"
       role="option"
diff --git a/src/components/selectable/selectable_list/selectable_list.tsx b/src/components/selectable/selectable_list/selectable_list.tsx
@@ -398,7 +398,6 @@ export class EuiSelectableList<T> extends Component<
           event.persist(); // NOTE: This is needed for React v16 backwards compatibility
           this.onAddOrRemoveOption(option, event);
         }}
-        ref={ref ? ref.bind(null, index) : undefined}
         isFocused={isFocused}
         title={searchableLabel || label}
         checked={checked}
diff --git a/src/components/selectable/selectable_list/selectable_list_item.tsx b/src/components/selectable/selectable_list/selectable_list_item.tsx
