Remove no-extra-semicolons stylelint rule

cee-chen · cee-chen · commit 28f17867ad56 · 2024-11-11T22:57:37.000-08:00
- at this point it's creating more false positives with nested template literals than it is being helpful
diff --git a/packages/eui/.stylelintrc.js b/packages/eui/.stylelintrc.js
@@ -151,9 +151,6 @@ module.exports = {
             ignoreKeywords: [camelCaseValueRegex],
           },
         ],
-        // This is set to deprecate after stylelint v16, but in the meanwhile, is helpful
-        // for finding extraneous semicolons after utils that already output semicolons (e.g. logicalCSS())
-        'no-extra-semicolons': true,
 
         // Emotion uses the `label` property to generate the output className string
         'property-no-unknown': [true, { ignoreProperties: 'label' }],
diff --git a/packages/eui/src/components/date_picker/react_date_picker.styles.ts b/packages/eui/src/components/date_picker/react_date_picker.styles.ts
@@ -249,7 +249,6 @@ export const _dayCalendarStyles = (euiThemeContext: UseEuiTheme) => {
     .react-datepicker__day-names,
     .react-datepicker__week {
       display: flex;
-      /* stylelint-disable no-extra-semicolons */
       justify-content: space-between;
       flex-grow: 1;
       color: ${euiTheme.colors.subduedText};
diff --git a/packages/eui/src/components/form/range/range_slider.styles.ts b/packages/eui/src/components/form/range/range_slider.styles.ts
@@ -65,7 +65,6 @@ export const euiRangeSliderStyles = (euiThemeContext: UseEuiTheme) => {
       block-size: ${range.thumbHeight}; /* the track has the same height as the thumb */
     `,
     hasRange: css`
-      /* stylelint-disable no-extra-semicolons */
       ${euiRangeTrackPerBrowser(`
         background-color: transparent;
         border-color: ${transparentize(range.trackBorderColor, 0.6)}
