Merge branch 'main' into fix/eui-plus-missing-content

weronikaolejniczak · web-flow · commit 208b739f1efd · 2025-02-12T16:04:10.000+01:00
diff --git a/packages/eui/changelogs/upcoming/8307.md b/packages/eui/changelogs/upcoming/8307.md
@@ -0,0 +1,2 @@
+- Updated `EuiInlineEditForm`'s `onCancel` prop type to allow uncontrolled mode usage
+
diff --git a/packages/eui/changelogs/upcoming/8311.md b/packages/eui/changelogs/upcoming/8311.md
@@ -0,0 +1,4 @@
+**Bug fixes**
+
+- Fixed a bug on `EuiSuperDatePicker` where pasting an absolute date would append the date instead of replace it
+
diff --git a/packages/eui/src/components/date_picker/super_date_picker/date_popover/absolute_tab.test.tsx b/packages/eui/src/components/date_picker/super_date_picker/date_popover/absolute_tab.test.tsx
@@ -7,11 +7,12 @@
  */
 
 import React from 'react';
-import { fireEvent } from '@testing-library/react';
+import { fireEvent, waitFor } from '@testing-library/react';
 import { render } from '../../../../test/rtl';
 
 import { EuiAbsoluteTab } from './absolute_tab';
 import { LocaleSpecifier } from 'moment';
+import { userEvent } from '@storybook/test';
 
 // Mock EuiDatePicker - 3rd party datepicker lib causes render issues
 jest.mock('../../date_picker', () => ({
@@ -69,7 +70,7 @@ describe('EuiAbsoluteTab', () => {
       expect(queryByText(formatHelpText)).toHaveClass('euiFormErrorText');
     });
 
-    it('immediately parses pasted text without needing an extra click or keypress', () => {
+    it('immediately parses pasted text without needing an extra click or keypress', async () => {
       const { getByTestSubject, queryByText } = render(
         <EuiAbsoluteTab {...props} />
       );
@@ -80,9 +81,21 @@ describe('EuiAbsoluteTab', () => {
       fireEvent.paste(input, {
         clipboardData: { getData: () => '1970-01-01' },
       });
+
       expect(input).not.toBeInvalid();
       expect(input.value).toContain('Jan 1, 1970');
 
+      // Additional pasting check as userEvent.paste more accurately simulates
+      // the pasting behavior with side effects
+      await waitFor(() => {
+        input.focus();
+        userEvent.paste('1970-01-02');
+      });
+
+      // ensure value is replaced, not appended
+      expect(input.value).not.toEqual('Jan 1, 1970 @ 00:00:00.0001970-01-02');
+      expect(input.value).toEqual('Jan 2, 1970 @ 00:00:00.000');
+
       input.value = '';
       fireEvent.paste(input, {
         clipboardData: { getData: () => 'not a date' },
diff --git a/packages/eui/src/components/date_picker/super_date_picker/date_popover/absolute_tab.tsx b/packages/eui/src/components/date_picker/super_date_picker/date_popover/absolute_tab.tsx
@@ -188,6 +188,10 @@ export const EuiAbsoluteTab: FunctionComponent<EuiAbsoluteTabProps> = ({
             value={textInputValue}
             onChange={handleTextChange}
             onPaste={(event) => {
+              // preventing default here ensures no additional onChange is
+              // triggered which otherwise results in input duplication
+              event.preventDefault();
+
               setTextInputValue(event.clipboardData.getData('text'));
               setIsReadyToParse(true);
             }}
diff --git a/packages/eui/src/components/inline_edit/inline_edit_form.tsx b/packages/eui/src/components/inline_edit/inline_edit_form.tsx
@@ -96,6 +96,7 @@ export type EuiInlineEditCommonProps = Omit<
        * Initial inline edit text value
        */
       defaultValue: string;
+      onCancel?: (previousValue: string) => void;
     },
     {
       /**
@@ -109,7 +110,7 @@ export type EuiInlineEditCommonProps = Omit<
       /**
        * Callback required to reset `value` to the previous read mode text value.
        */
-      onCancel: (perviousValue: string) => void;
+      onCancel: (previousValue: string) => void;
     }
   >;
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+- Updated `EuiInlineEditForm`'s `onCancel` prop type to allow uncontrolled mode usage
	`2`	`+`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +**Bug fixes**
++
 +- Fixed a bug on `EuiSuperDatePicker` where pasting an absolute date would append the date instead of replace it
++