Copy tweaks

cee-chen · cee-chen · commit 1b59e3265986 · 2024-01-24T11:16:20.000-08:00
diff --git a/changelogs/upcoming/7468.md b/changelogs/upcoming/7468.md
@@ -1,3 +1,3 @@
 **Bug fixes**
 
-- Fixed an issue in `EuiResizableContainer` where `onResizeEnd` becomes a stale closure when renders occur between resize start and end. This can result in an outdated version of a consumer's `onResizeEnd` callback being called on resize end.
+- Fixed an issue in `EuiResizableContainer` where `onResizeEnd` could become a stale closure when renders occured between resize start and end, resulting in an outdated version of a consumer's `onResizeEnd` callback being called
diff --git a/src/components/resizable_container/resizable_container.test.tsx b/src/components/resizable_container/resizable_container.test.tsx
@@ -350,7 +350,7 @@ describe('EuiResizableContainer', () => {
       expect(onResizeEnd).toHaveBeenCalledTimes(1);
     });
 
-    test('unmemoized consumer onResizeStart/End callbacks are handled', () => {
+    test('unmemoized consumer onResizeStart/End callbacks do not cause stale closures', () => {
       const ConsumerUsage = () => {
         const [rerender, setRerender] = useState(0);
         // Unmemoized consumer callbacks
@@ -387,7 +387,8 @@ describe('EuiResizableContainer', () => {
 
       fireEvent.mouseUp(getByTestSubject('euiResizableButton'));
       expect(getByTestSubject('rerenders')).toHaveTextContent('2');
-      // Without `useLatest`, the rerender count doesn't correctly update due to `onResizeEnd` not being memoized and causing the wrong `resizeEnd` to be called on event listener end
+      // Without `useLatest`, the rerender count doesn't correctly update due to `onResizeEnd`
+      // not being memoized and causing a stale `resizeEnd` closure to be called on event end
     });
   });
 });
diff --git a/src/components/resizable_container/resizable_container.tsx b/src/components/resizable_container/resizable_container.tsx
@@ -101,7 +101,7 @@ export const EuiResizableContainer: FunctionComponent<
   ...rest
 }) => {
   // Note: It's important to memoize consumer callbacks to prevent our own functions
-  // from reinstantiating unnecessarily and breaking our window event listeners
+  // from reinstantiating unnecessarily & causing window event listeners to call stale closures
   const onResizeEndRef = useLatest(onResizeEnd);
   const onResizeStartRef = useLatest(onResizeStart);
   const containerRef = useRef<HTMLDivElement>(null);

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`Bug fixes`
`2`	`2`
`3`		-- Fixed an issue in `EuiResizableContainer` where `onResizeEnd` becomes a stale closure when renders occur between resize start and end. This can result in an outdated version of a consumer's `onResizeEnd` callback being called on resize end.
	`3`	+- Fixed an issue in `EuiResizableContainer` where `onResizeEnd` could become a stale closure when renders occured between resize start and end, resulting in an outdated version of a consumer's `onResizeEnd` callback being called