Removed noDivider prop from EuiFilterButton

cee-chen · cee-chen · commit 07f034810094 · 2022-05-04T11:54:23.000-07:00
diff --git a/src/components/filter_group/filter_button.tsx b/src/components/filter_group/filter_button.tsx
@@ -43,11 +43,6 @@ export type EuiFilterButtonProps = {
    * Remove border after button, good for opposite filters
    */
   withNext?: boolean;
-  /**
-   * _DEPRECATED: use `withNext`_
-   * Remove border after button, good for opposite filters
-   */
-  noDivider?: boolean;
 } & DistributiveOmit<EuiButtonEmptyProps, 'flush' | 'size'>;
 
 export const EuiFilterButton: FunctionComponent<EuiFilterButtonProps> = ({
@@ -63,7 +58,6 @@ export const EuiFilterButton: FunctionComponent<EuiFilterButtonProps> = ({
   isSelected,
   type = 'button',
   grow = true,
-  noDivider,
   withNext,
   textProps,
   ...rest
@@ -80,7 +74,7 @@ export const EuiFilterButton: FunctionComponent<EuiFilterButtonProps> = ({
       'euiFilterButton-hasNotification': numFiltersDefined,
       'euiFilterButton--hasIcon': iconType,
       'euiFilterButton--noGrow': !grow,
-      'euiFilterButton--withNext': noDivider || withNext,
+      'euiFilterButton--withNext': withNext,
     },
     className
   );
diff --git a/src/components/search_bar/filters/__snapshots__/field_value_toggle_group_filter.test.tsx.snap b/src/components/search_bar/filters/__snapshots__/field_value_toggle_group_filter.test.tsx.snap
@@ -6,7 +6,6 @@ Array [
     aria-pressed={true}
     hasActiveFilters={true}
     key="field_value_toggle_filter_item_0"
-    noDivider={true}
     onClick={[Function]}
     withNext={true}
   >
@@ -16,7 +15,6 @@ Array [
     aria-pressed={false}
     hasActiveFilters={false}
     key="field_value_toggle_filter_item_1"
-    noDivider={false}
     onClick={[Function]}
     withNext={false}
   >
@@ -31,7 +29,6 @@ Array [
     aria-pressed={true}
     hasActiveFilters={true}
     key="field_value_toggle_filter_item_0"
-    noDivider={true}
     onClick={[Function]}
     withNext={true}
   >
@@ -41,7 +38,6 @@ Array [
     aria-pressed={false}
     hasActiveFilters={false}
     key="field_value_toggle_filter_item_1"
-    noDivider={false}
     onClick={[Function]}
     withNext={false}
   >
@@ -56,7 +52,6 @@ Array [
     aria-pressed={true}
     hasActiveFilters={true}
     key="field_value_toggle_filter_item_0"
-    noDivider={true}
     onClick={[Function]}
     withNext={true}
   >
@@ -66,7 +61,6 @@ Array [
     aria-pressed={false}
     hasActiveFilters={false}
     key="field_value_toggle_filter_item_1"
-    noDivider={false}
     onClick={[Function]}
     withNext={false}
   >
@@ -81,7 +75,6 @@ Array [
     aria-pressed={false}
     hasActiveFilters={false}
     key="field_value_toggle_filter_item_0"
-    noDivider={true}
     onClick={[Function]}
     withNext={true}
   >
@@ -91,7 +84,6 @@ Array [
     aria-pressed={false}
     hasActiveFilters={false}
     key="field_value_toggle_filter_item_1"
-    noDivider={false}
     onClick={[Function]}
     withNext={false}
   >
diff --git a/src/components/search_bar/filters/field_value_toggle_group_filter.tsx b/src/components/search_bar/filters/field_value_toggle_group_filter.tsx
@@ -81,7 +81,6 @@ export class FieldValueToggleGroupFilter extends Component<
           key={key}
           onClick={onClick}
           hasActiveFilters={active}
-          noDivider={!isLastItem}
           aria-pressed={!!active}
           withNext={!isLastItem}
         >
diff --git a/upcoming_changelogs/5868.md b/upcoming_changelogs/5868.md
@@ -3,3 +3,4 @@
 - Removed deprecated options for `EuiDatePicker`'s `popoverPosition` props - use `EuiPopover` values going forward
 - Removed `partition` prop from EuiCharts theme configuration - use `theme.partition` instead
 - Removed `data-grid-cell-id` attribute from `EuiDataGrid` cells - use separate `data-gridcell-column-id` & `data-gridcell-row-index` attributes instead
+- Removed `noDivider` prop from `EuiFilterButton` - use `withNext` prop instead

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,6 @@ export class FieldValueToggleGroupFilter extends Component<`
`81`	`81`	`key={key}`
`82`	`82`	`onClick={onClick}`
`83`	`83`	`hasActiveFilters={active}`
`84`		`- noDivider={!isLastItem}`
`85`	`84`	`aria-pressed={!!active}`
`86`	`85`	`withNext={!isLastItem}`
`87`	`86`	`>`