[7.6] Define URLs for tile and file APIs#13
Merged
nickpeihl merged 11 commits intoelastic:masterfrom Jan 13, 2020
Merged
Conversation
This was referenced Jan 9, 2020
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
some minor comments, thanks!
src/ems_client.js
Outdated
| import { format as formatUrl, parse as parseUrl } from 'url'; | ||
|
|
||
| // TODO should we parse this from package.json? | ||
| const EMS_VERSION = '7.6'; |
Contributor
There was a problem hiding this comment.
I think we can leave this as-is for now, but we should add this to readme that this needs to get updated if we publish a new version.
I would also rename to DEFAULT_EMS_VERSION.
Contributor
Author
There was a problem hiding this comment.
we should add this to readme that this needs to get updated if we publish a new version.
Good idea. I'll add it to this PR for CONTRIBUTING.md.
thomasneirynck
approved these changes
Jan 13, 2020
src/utils.js
Outdated
|
|
||
| /** | ||
| * Resolves a target URL path relative to the host. | ||
| * This is specifically usefed by the Kibana proxy re-routing. |
Contributor
There was a problem hiding this comment.
usefeeding sounds like agro-industrial jargon.
Contributor
|
Feel free to publish to npm. If we need to revisit, we can always publish patch. Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on elastic/ems-file-service#143
This updates ems-client to work with the changes in EMS v7.6. The EMS v7.6 API will no longer have a catalogue manifest and URLs in the tile and vector manifests will be changed from absolute to relative. See elastic/ems-file-service#143
ems-client@7.6 now accepts two new parameters (
tileApiUrlandfileApiUrl) which are expected to be the basepath for the API (e.g.https://tiles.maps.elastic.coandhttps://files.maps.elastic.co).Since the basepath for each API is configurable, we should no longer need theproxyPathparameter. The URLs to the proxy services with the required endpoints are all that is needed.