[OTel instrumentation] Add path params and endpoint in opts to perform_request#2179
Merged
picandocodigo merged 48 commits intoelastic:mainfrom Sep 29, 2023
Merged
[OTel instrumentation] Add path params and endpoint in opts to perform_request#2179picandocodigo merged 48 commits intoelastic:mainfrom
picandocodigo merged 48 commits intoelastic:mainfrom
Conversation
f7938c6 to
f56b5e8
Compare
8 tasks
e62c191 to
d6bb5f7
Compare
ae28cef to
20207a9
Compare
estolfo
commented
Sep 26, 2023
szabosteve
approved these changes
Sep 27, 2023
Contributor
szabosteve
left a comment
There was a problem hiding this comment.
Thanks for writing this up! I left some smaller suggestions, please take or leave them. Documentation changes LGTM!
picandocodigo
approved these changes
Sep 29, 2023
Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Update docs/open-telemetry.asciidoc Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Minor change to docs
98a243d to
55c8651
Compare
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements a PR in the transport client
This PR does the following:
perform_requestargs list so that the transport client can use the values for the OpenTelemetry instrumentationperform_requestmethod signature (code was regenerated)