Skip to content

Sum on stats aggregation always returns a value#3834

Merged
Mpdreamz merged 1 commit into7.xfrom
fix/elasticsearch-27193
Jun 20, 2019
Merged

Sum on stats aggregation always returns a value#3834
Mpdreamz merged 1 commit into7.xfrom
fix/elasticsearch-27193

Conversation

@russcam
Copy link
Copy Markdown
Contributor

@russcam russcam commented Jun 20, 2019

Relates: elastic/elasticsearch#27193

This commit updates Sum property on StatsAggregate to be modelled as non-nullable and to derive ExtendedStatsAggregate from StatsAggregate. Adds integration test to assert deserialization behaviour.

Relates: elastic/elasticsearch#27193

This commit updates Sum property on StatsAggregate to be modelled as non-nullable and to derive ExtendedStatsAggregate from StatsAggregate. Adds integration test to assert deserialization behaviour.
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the upstream PR too

@Mpdreamz Mpdreamz merged commit 4f64167 into 7.x Jun 20, 2019
@Mpdreamz Mpdreamz deleted the fix/elasticsearch-27193 branch June 20, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants