Closes #3251. Rename levenstein to levenshtein.#3264
Merged
Conversation
Mpdreamz
requested changes
May 30, 2018
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
+1 to renaming the enum in master and adding it as an additional enum value in the backport while obsoleting the misspelled variant.
Contributor
Author
|
Ported to |
Contributor
|
@codebrain this can't be backported to 6.x because e.g. Elasticsearch 6.0 uses |
Member
|
Think this was merged to soon, should still rename the enum in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure if we should rename the enumeration value at this stage as it would break binary compatibility.
Potentially consider implementing another enumeration value with the correct spelling? @russcam - thoughts?