Conversation
russcam
suggested changes
May 4, 2017
Contributor
russcam
left a comment
There was a problem hiding this comment.
some small comments, otherwise LGTM 👍
| public class XPackBuildInformation | ||
| { | ||
| [JsonProperty("date")] | ||
| public DateTime Date { get; internal set; } |
Contributor
There was a problem hiding this comment.
thoughts on using DateTimeOffset?
| public LicenseStatus Status { get; internal set; } | ||
|
|
||
| [JsonProperty("expiry_date_in_millis")] | ||
| public long ExpiryDateInMilliseconds { get; set; } |
Contributor
There was a problem hiding this comment.
Should we expose a DateTime/DateTimeOffset property for this?
Member
Author
There was a problem hiding this comment.
I'm going to leave this as, might be useful for elasticsearch itself to start returning date.
|
|
||
| ///<summary>descriptor for XpackInfo <pre>Retrieve information about xpack, including build number/timestamp and license status</pre></summary> | ||
| public partial class XpackInfoDescriptor : RequestDescriptorBase<XpackInfoDescriptor,XpackInfoRequestParameters, IXpackInfoRequest>, IXpackInfoRequest | ||
| public partial class XPackInfoDescriptor : RequestDescriptorBase<XPackInfoDescriptor,XPackInfoRequestParameters, IXPackInfoRequest>, IXPackInfoRequest |
Contributor
There was a problem hiding this comment.
These change the casing of Xpack -> XPack. Should we keep the casing as is here for bwc and update in master?
Member
Author
There was a problem hiding this comment.
They change the casing against the generated code in 5.4. 5.x and master do not have this yet so we're good 👍
945f242 to
d1efdc4
Compare
russcam
approved these changes
May 4, 2017
Merged
Member
Author
|
ported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.