Reduce forking in CCR repo#98123
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Aug 2, 2023
Merged
Conversation
Today we deserialize the chunks received when creating a follower on the CCR pool (prior to elastic#97922 this was the transport thread) and then manually fork off to the GENERIC pool to write the chunk to disk. It's simpler just to do all this on the GENERIC pool to start with, so this commit does that.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we deserialize the chunks received when creating a follower on the
CCR pool (prior to #97922 this was the transport thread) and then
manually fork off to the GENERIC pool to write the chunk to disk. It's
simpler just to do all this on the GENERIC pool to start with, so this
commit does that.