[SAML] Filter potential signing keys by algorithm#98119
Merged
tvernum merged 1 commit intoelastic:mainfrom Aug 4, 2023
Merged
Conversation
When performing signature verification, skip any keys that have a non-matching algorithm. This is needed in order to upgrade to newer versions of OpenSAML (e.g. 4.3) because of changes in how the underlying (saml) Signature object stores state between verification attempts - in newer version attempting to verify with an incompatible key will put the signature into a state that it cannot recover from and all future verification attempts will fail.
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
albertzaharovits
approved these changes
Aug 2, 2023
Contributor
albertzaharovits
left a comment
There was a problem hiding this comment.
LGTM kudos for toubleshooting!
Contributor
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
Contributor
|
Failure https://gradle-enterprise.elastic.co/s/2km5aa2ea324i is tracked under #98053 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing signature verification, skip any keys that have a non-matching algorithm.
This is needed in order to upgrade to newer versions of OpenSAML (e.g. 4.3) because of changes in how the underlying (saml) Signature object stores state between verification attempts - in newer version attempting to verify with an incompatible key will put the signature into a state that it cannot recover from and all future verification attempts will fail.