[testcluster] Fix merging of JVM args#97776
Merged
tvernum merged 2 commits intoelastic:mainfrom Jul 25, 2023
Merged
Conversation
If the system properties and jvm args are both non-empty then we need a space between them.
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
| + " " | ||
| + featureFlagProperties | ||
| + systemProperties | ||
| + ' ' |
Contributor
There was a problem hiding this comment.
Good sleuthing! Do we have the same potential issue between all these string values? Maybe we should build this string in a similar way to previous ones, with a stream and joiner.
Member
There was a problem hiding this comment.
I agree, a stream and joiner would seem more robust.
Contributor
Author
There was a problem hiding this comment.
Yeah, sorry about that. It was the end of the day and I wanted to get something out the door, so I ignored the screaming voice inside me telling me how dirty the fix was.
🙀
Updated in d6ea5b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the system properties and jvm args are both non-empty then we need a space between them.