Making sure that watcher history indices are green before querying them#95642
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Apr 27, 2023
Merged
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Member
Author
|
Adding a little more evidence to the fact that #94133 caused this -- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My theory is that the failure at #95077 was caused by #94133. It looks like the test is failing because the watcher history index exists, but not all shards have been allocated. Previously the bulk processor used to load watcher history was blocking. So if the watch completed you were guaranteed that the watcher history shards had been allocated because it didn't return until the watcher history documents had been written. The new bulk processor works asynchrnously, and doesn't block watcher.
This change waits until the watcher history indices are green (all shards allocated) before querying them.
Closes #95077