Skip to content

Re-enable concurrent search on script field type tests#95280

Merged
romseygeek merged 2 commits intoelastic:mainfrom
romseygeek:test-script-concurrency
Apr 17, 2023
Merged

Re-enable concurrent search on script field type tests#95280
romseygeek merged 2 commits intoelastic:mainfrom
romseygeek:test-script-concurrency

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

This commit reverts #90712, which disabled concurrency on runtime
field scripts. Since #95082 these scripts should be thread-safe, and so
we can use the standard test searcher methods which may randomly
add multi-threaded search.

@romseygeek romseygeek added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.8.0 labels Apr 17, 2023
@romseygeek romseygeek requested review from cbuescher and javanna April 17, 2023 09:20
@romseygeek romseygeek self-assigned this Apr 17, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Apr 17, 2023
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Copy Markdown
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks. Briefly looking at #95082 these tests look okay to be enabled again now.

@romseygeek
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/part-1
@elasticmachine run elasticsearch-ci/bwc

@romseygeek
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@romseygeek
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample

@romseygeek romseygeek merged commit 6cfafcf into elastic:main Apr 17, 2023
@romseygeek romseygeek deleted the test-script-concurrency branch April 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants