Testing: Add test rule to repeat tests on binding exceptions#9527
Merged
spinscale merged 1 commit intoelastic:masterfrom Feb 9, 2015
Merged
Conversation
Member
|
LGTM, just a couple minor comments. |
cd31cc8 to
86ce3a9
Compare
86ce3a9 to
db04c17
Compare
Due to the possibility of ports being already used when choosing a random port, it makes sense to simply repeat a unit test upon a bind exception. This commit adds a junit rule, which does exactly this and does not require you to change the test code and add loops. Closes elastic#9010
db04c17 to
98a2482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the possibility of ports being already used when choosing a
random port, it makes sense to simply repeat a unit test upon a bind
exception.
This commit adds a junit rule, which does exactly this and does not
require you to change the test code and add loops.
Closes #9010