Expand tests for geo_grid aggregations#94747
Merged
craigtaverner merged 2 commits intoelastic:mainfrom Mar 27, 2023
Merged
Conversation
geohex is doubled to support both geo_point and geo_shape, while geotile and geohash are expanded to cover same range as geohex, covering the various options supported like: * precision * size * shard_size * bounds
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
69 tasks
The tests in the aggregation module covered geo_point. We had added additional tests in xpack for geo_shape, so we expand that coverage here to geo_point in the aggregations module.
iverase
approved these changes
Mar 27, 2023
Contributor
iverase
left a comment
There was a problem hiding this comment.
Thanks for expanding the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for geohex are doubled to support both geo_point and geo_shape, while geotile and geohash are expanded to cover same range as geohex, covering the various options supported like:
Before this PR, the test coverage was:
With the PR we now have:
Note that the tests are in two locations:
For testing these two locations, different commands are used:
For
modules/aggregations, eg. test geotile_grid over geo_point:For
x-pack/plugin, eg. test geohash_grid over geo_shape: