Deprioritize master service#94318
Merged
DaveCTurner merged 2 commits intoelastic:mainfrom Mar 6, 2023
Merged
Conversation
The changes introduced in elastic#92021 mean that the master service no longer needs to use a prioritized executor. Prioritized executors are weird, for instance they don't propagate rejections to `AbstractRunnable` tasks properly. This commit moves to using a regular scaling executor and removes some of the now-unnecessary workarounds for handling the prioritized executor's weirdness.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Mar 6, 2023
| @Override | ||
| protected PrioritizedEsThreadPoolExecutor createThreadPoolExecutor() { | ||
| protected ExecutorService createThreadPoolExecutor() { | ||
| return new PrioritizedEsThreadPoolExecutor( |
Member
Author
There was a problem hiding this comment.
I will address this one more thoroughly in a followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes introduced in #92021 mean that the master service no longer needs to use a prioritized executor. Prioritized executors are weird, for instance they don't propagate rejections to
AbstractRunnabletasks properly. This commit moves to using a regular scaling executor and removes some of the now-unnecessary workarounds for handling the prioritized executor's weirdness.