Skip to content

Updating assorted integration tests to use BulkProcessor2 instead of BulkProcessor#94172

Merged
elasticsearchmachine merged 5 commits intoelastic:mainfrom
masseyke:using-bulkprocessor2-in-integration-tests
Mar 3, 2023
Merged

Updating assorted integration tests to use BulkProcessor2 instead of BulkProcessor#94172
elasticsearchmachine merged 5 commits intoelastic:mainfrom
masseyke:using-bulkprocessor2-in-integration-tests

Conversation

@masseyke
Copy link
Copy Markdown
Member

In #91238 we rewrote BulkProcessor to avoid deadlock that had been seen in the IlmHistoryStore. At some point we will remove BulkProcessor altogether. This PR ports a couple of integration tests that were using BulkProcesor over to BulkProcessor2.

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Other v8.8.0 labels Feb 27, 2023
@masseyke masseyke marked this pull request as ready for review March 2, 2023 14:45
@masseyke masseyke requested a review from dakrone March 2, 2023 14:45
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Mar 2, 2023
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Mar 2, 2023

@elasticmachine run elasticsearch-ci/eql-correctness

@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Mar 2, 2023

@elasticmachine run elasticsearch-ci/part-2

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Mar 2, 2023

@elasticmachine update branch

@masseyke masseyke added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 2, 2023
@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Mar 2, 2023

@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample

@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Mar 2, 2023

@elasticmchine run elasticsearch-ci/packaging-tests-windows-sample

@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Mar 2, 2023

@elasticmachine update branch

@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Mar 3, 2023

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit b18c036 into elastic:main Mar 3, 2023
@masseyke masseyke deleted the using-bulkprocessor2-in-integration-tests branch March 3, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Data Management (obsolete) DO NOT USE. This team no longer exists. >test Issues or PRs that are addressing/adding tests v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants