[8.6] Fix Chunked APIs sending incorrect responses to HEAD requests (#92042)#92049
Merged
elasticsearchmachine merged 3 commits intoelastic:8.6from Jan 3, 2023
original-brownbear:backport/8.6/pr-92042
Merged
[8.6] Fix Chunked APIs sending incorrect responses to HEAD requests (#92042)#92049elasticsearchmachine merged 3 commits intoelastic:8.6from original-brownbear:backport/8.6/pr-92042
elasticsearchmachine merged 3 commits intoelastic:8.6from
original-brownbear:backport/8.6/pr-92042
Conversation
Response bodies must always be empty for HEAD requests. Since the request encoder does not know that its dealing with a response to a HEAD request we have to indicate this fact to it. Also, needed to adjust the test http client to use the http-codec so it is able to correlate what responses are meant for HEAD requests and will correctly read responses for HEAD requests. Without this change the added test reproduces the extra bytes and fails with an assert about more than one response received. closes #92032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.6: