Chunked FieldUsageStatsResponse#91942
Merged
original-brownbear merged 2 commits intoelastic:mainfrom Nov 25, 2022
original-brownbear:chunk-field-stats
Merged
Chunked FieldUsageStatsResponse#91942original-brownbear merged 2 commits intoelastic:mainfrom original-brownbear:chunk-field-stats
original-brownbear merged 2 commits intoelastic:mainfrom
original-brownbear:chunk-field-stats
Conversation
These responses can become extremely large, chunk them.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
19 tasks
DaveCTurner
approved these changes
Nov 25, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM mod a couple of test comments
| public class FieldUsageStatsResponseTests extends ESTestCase { | ||
|
|
||
| public void testToXContentChunkPerIndex() { | ||
| final int indices = randomIntBetween(1, 100); |
Member
There was a problem hiding this comment.
May as well check this corner case too
Suggested change
| final int indices = randomIntBetween(1, 100); | |
| final int indices = randomIntBetween(0, 100); |
Comment on lines
+50
to
+53
| while (iterator.hasNext()) { | ||
| iterator.next(); | ||
| chunks++; | ||
| } |
Member
There was a problem hiding this comment.
I suggest writing the chunks to an actual builder to verify they produce a well-formed document.
Contributor
Author
|
Thanks David! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These responses can become extremely large, chunk them.