Chunked encoding for tasks APIs#91935
Merged
DaveCTurner merged 5 commits intoelastic:mainfrom Nov 28, 2022
Merged
Conversation
This response can reach many MiB in size in a large and busy cluster, let's use chunking here. Relates elastic#89838
19 tasks
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
Looks good, just one spot to fix I think :)
| @SafeVarargs | ||
| @SuppressWarnings("varargs") | ||
| public static <T> Stream<T> concat(Stream<T>... streams) { | ||
| if (streams.length == 0) { |
Contributor
There was a problem hiding this comment.
Why not just return Arrays.stream(streams).flatMap(Function.identity()); ? We might even get into stack depth troubles if we use the concat like we do here?
The docs for concat state:
Use caution when constructing streams from repeated concatenation. Accessing an element of a deeply concatenated stream can result in deep call chains, or even StackOverflowError.
Subsequent changes to the sequential/parallel execution mode of the returned stream are not guaranteed to be propagated to the input streams.
Member
Author
There was a problem hiding this comment.
We might even get into stack depth troubles
Touché 😁
Yeah you're right .flatMap(Function.identity()) is better here, no need for a utility to do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This response can reach many MiB in size in a large and busy cluster, let's use chunking here.
Relates #89838