Check stable plugin version at install and load time#91780
Merged
williamrandolph merged 3 commits intoelastic:mainfrom Nov 23, 2022
Merged
Check stable plugin version at install and load time#91780williamrandolph merged 3 commits intoelastic:mainfrom
williamrandolph merged 3 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @williamrandolph, I've created a changelog YAML for you. |
rjernst
approved these changes
Nov 21, 2022
Member
rjernst
left a comment
There was a problem hiding this comment.
LGTM. One suggestion on the tests.
| "my_plugin", | ||
| "desc", | ||
| "1.0", | ||
| Version.fromId(Version.CURRENT.id + 1), |
Member
There was a problem hiding this comment.
Since all we care about changing is the version, a utility for creating a descriptor with a specific Version would reduce a lot of boilerplate in these tests. Before the only case to change the version was in testIncompatibleElasticsearchVersion(), but this adds 2 more, so I would combine them to make the tests easier to read. Something like newTestDescriptorForVersion(Version v)
pgomulka
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a node to install a stable plugin, the node's Elasticsearch version must have the same major version as the Elasticsearch libraries against which the stable plugin was built. Additionally, a node will reject stable plugins that have been built with a future version of Elasticsearch.