Fix corrupted Metadata from index and alias having the same name (#91456)#91469
Merged
elasticsearchmachine merged 1 commit intoelastic:8.5from Nov 9, 2022
original-brownbear:91456-8.5
Merged
Fix corrupted Metadata from index and alias having the same name (#91456)#91469elasticsearchmachine merged 1 commit intoelastic:8.5from original-brownbear:91456-8.5
elasticsearchmachine merged 1 commit intoelastic:8.5from
original-brownbear:91456-8.5
Conversation
) This fixes a bug introduced in #87863 which added a Metadata copy constructor with separate name collision checks that assumed index name and alias names were already validated in `IndexMetada`. => fixed corrupted states by actually adding the validation to `IndexMetadata` to make it impossible to instantiate a broken `IndexMetadata` in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #87863 which added a Metadata copy constructor with separate name collision checks that assumed index name and alias names were already validated in
IndexMetada. => fixed corrupted states by actually adding the validation toIndexMetadatato make it impossible to instantiate a brokenIndexMetadatain the first place.back port of #91456