Fix SingleNodeDiscoveryStabilisesEvenWhenDisrupted#91325
Merged
kingherc merged 4 commits intoelastic:mainfrom Nov 7, 2022
Merged
Fix SingleNodeDiscoveryStabilisesEvenWhenDisrupted#91325kingherc merged 4 commits intoelastic:mainfrom
kingherc merged 4 commits intoelastic:mainfrom
Conversation
By increasing the voting duration in case of high delays, to avoid the possible endless repetition of voting rounds. Fixes elastic#89867
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Nov 7, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
I expect this will eventually fail because an election involves a couple of round-trips through the transport layer so should sometimes take as much as 4*delayVariabilityMillis (possibly longer, I didn't look for other delays). However I've run over 30,000 iterations of this test without seeing a failure, so maybe I'm misunderstanding or maybe with this delay a bad collision just becomes very unlikely. So empirically this LGTM (except for a couple of nits).
server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java
Show resolved
Hide resolved
…ordinatorTests.java Co-authored-by: David Turner <david.turner@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By increasing the voting duration in case of high
delays, to avoid the possible endless repetition
of voting rounds.
Fixes #89867