Skip to content

Rename NamedComponent name parameter to value#91306

Merged
pgomulka merged 4 commits intoelastic:mainfrom
pgomulka:named_component_value
Nov 4, 2022
Merged

Rename NamedComponent name parameter to value#91306
pgomulka merged 4 commits intoelastic:mainfrom
pgomulka:named_component_value

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Nov 4, 2022

to allow @NamedComponent("name") syntax java annotation should have single value annotation

relates #88980

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

to allow @NamedComponent("name") syntax java annotation should
have single value annotation

relates elastic#88980
@pgomulka pgomulka added >enhancement :Core/Infra/Plugins Plugin API and infrastructure v8.6.0 labels Nov 4, 2022
@pgomulka pgomulka self-assigned this Nov 4, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Nov 4, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @pgomulka, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka mentioned this pull request Nov 4, 2022
25 tasks
@pgomulka pgomulka merged commit 73ad49a into elastic:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Plugins Plugin API and infrastructure >enhancement Team:Core/Infra Meta label for core/infra team v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants