[8.5] Ensure cleanups succeed in JoinValidationService (#90601)#91253
Merged
elasticsearchmachine merged 1 commit intoelastic:8.5from Nov 2, 2022
Merged
[8.5] Ensure cleanups succeed in JoinValidationService (#90601)#91253elasticsearchmachine merged 1 commit intoelastic:8.5from
elasticsearchmachine merged 1 commit intoelastic:8.5from
Conversation
Today we sort of assume that cleanups succeed in the `JoinValidationService`. A failure in these places might explain the leaks seen in elastic#90576 and elastic#89712. It's not obvious that anything can fail here but let's make sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.5: