Skip to content

[8.5] Fix APM configuration file delete (#91058)#91250

Merged
elasticsearchmachine merged 1 commit intoelastic:8.5from
grcevski:backport/8.5/pr-91058
Nov 2, 2022
Merged

[8.5] Fix APM configuration file delete (#91058)#91250
elasticsearchmachine merged 1 commit intoelastic:8.5from
grcevski:backport/8.5/pr-91058

Conversation

@grcevski
Copy link
Copy Markdown
Contributor

@grcevski grcevski commented Nov 2, 2022

Backports the following commits to 8.5:

When we launch Elasticsearch with the APM monitoring
agent, we create a temporary configuration file to
securely pass the API key or secret. This temporary
file is cleaned up on Elasticsearch Node creation.

After we renamed the APM module, the delete logic
didn't get updated, which means we never delete the file
anymore.

This commit:
 - fixes the APM module pattern match when we delete
 - adds additional delete safety net on failed node start
 - adds tests for ensuring the naming dependency isn't
   broken again.
@grcevski grcevski added :Core/Infra/Core Core issues without another label >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team labels Nov 2, 2022
@elasticsearchmachine elasticsearchmachine merged commit ebb6d52 into elastic:8.5 Nov 2, 2022
@grcevski grcevski deleted the backport/8.5/pr-91058 branch November 2, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.5.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants