Move composite aggregation to aggregations module.#90954
Closed
martijnvg wants to merge 20 commits intoelastic:mainfrom
Closed
Move composite aggregation to aggregations module.#90954martijnvg wants to merge 20 commits intoelastic:mainfrom
martijnvg wants to merge 20 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
Oct 17, 2022
60 tasks
With the move of a the composite aggs code to the aggregations plugin, this effectively renders the aggregation plugin as an Extensible plugin ( since x-pack-core uses the composite aggs code directly ). The X-pack-core plugin then requires to "extend" the aggregation plugin, so that the classloader hierarchy is setup correctly at runtime. Following all this, lang-painless is now transitively required (by the aggregations plugin ), for all plugins extending x-pack-core, so we need to move it as an explicit "extends" from plugins that extend from x-pack-core
…t when building named xcontent registry. These tests use composite aggregation and because this aggregation moved to aggregation module as part of this change these tests need this tweak.
nik9000
reviewed
Jan 10, 2023
| import java.util.List; | ||
|
|
||
| public class AggregationsPlugin extends Plugin implements SearchPlugin, ScriptPlugin { | ||
| public class AggregationsPlugin extends Plugin implements ExtensiblePlugin, SearchPlugin, ScriptPlugin { |
Member
There was a problem hiding this comment.
Do we use ExtensiblePlugin yet?
| ); | ||
| } | ||
|
|
||
| private void assertMap(Map<String, Map<String, Object>> debug, MapMatcher name) {} |
| description 'Module for the constant-keyword field type, which is a specialization of keyword for the case when all documents have the same value.' | ||
| classname 'org.elasticsearch.xpack.constantkeyword.ConstantKeywordMapperPlugin' | ||
| extendedPlugins = ['x-pack-core', 'lang-painless'] | ||
| extendedPlugins = ['x-pack-core'] |
Member
There was a problem hiding this comment.
Oh wild. So they get the extension transitively through x-pack-core -> aggregations -> lang-painless? That seems odd. Does x-pack-core extend aggregations just so it can see it or something else? I'm not entirely clear on when you'd do what with the extension mechanism.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #90283