Create placeholder plugin when loading stable plugins#90870
Merged
pgomulka merged 4 commits intoelastic:mainfrom Oct 14, 2022
Merged
Create placeholder plugin when loading stable plugins#90870pgomulka merged 4 commits intoelastic:mainfrom
pgomulka merged 4 commits intoelastic:mainfrom
Conversation
Stable plugins do not extend Plugin class and are not instantiated in PluginService. Therefore a simple StablePluginPlaceHolder has to be used in order to make pluginService aware of the plugin and its descriptor. It is needed to return information about loaded stable plugins in cluster state. relates elastic#88980
Collaborator
|
Hi @pgomulka, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
…o stable_plugin_placeholder
grcevski
approved these changes
Oct 13, 2022
Contributor
grcevski
left a comment
There was a problem hiding this comment.
LGTM! I'm excited about this change, because I think this brings us closer to the possibility of installing/removing plugins without node restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stable plugins do not extend Plugin class and are not instantiated in PluginService. Therefore a simple StablePluginPlaceHolder has to be used in order to make pluginService aware of the plugin and its descriptor. It is needed to return information about loaded stable plugins in cluster state.
relates #88980
gradle check?