[8.5] [Tests] Don't use concurrent search in scripted field type tests (#90712)#90716
Merged
elasticsearchmachine merged 1 commit intoelastic:8.5from Oct 6, 2022
Merged
Conversation
…stic#90712) The field types in these tests use scripts which accesses _source via SourceLookup, which in turn isn't thread-safe. Since ES doesn't use concurent search on the Lucene level it is safe to disable the otherwise randomized use of multiple threads in searchers. This change adds a new helper method for that in AbstractScriptFieldTypeTestCase which all of the sub-test use. Closes elastic#90497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.5: