Release aggregator context in tests#90540
Merged
not-napoleon merged 9 commits intoelastic:mainfrom Oct 4, 2022
Merged
Conversation
Conflicts: test/framework/src/main/java/org/elasticsearch/search/aggregations/AggregatorTestCase.java
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
nik9000
approved these changes
Oct 3, 2022
This was referenced Oct 10, 2022
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #89437
This attempts to mirror the production memory release cycle in the most common branch of the aggregations unit tests. As many tests do not follow that branch, there are additional changes around making those branches release allocated memory, although I do not intend them to simulate production in any meaningful way.
This is basically "part 1" of this work. In the course of working on this, Nik and I uncovered a bug in the aggregations testing framework that disabled the
MockBigArraysleak checking in many tests. I have a fix for that, and am working through fixing related test failures, but I think it makes more sense to add that in a separate PR. That'll keep the reviews shorter, and get the benefit of this memory testing available to the rest of the team sooner.