Merged
Conversation
Registering a file for watching can fail because the OS may not have enough inotify keys to hand out. Before failing to start the watch service, we should retry few times to ensure the OS situation isn't temporary.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @grcevski, I've created a changelog YAML for you. |
thecoop
reviewed
Sep 30, 2022
server/src/main/java/org/elasticsearch/reservedstate/service/FileSettingsService.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Sep 30, 2022
server/src/main/java/org/elasticsearch/reservedstate/service/FileSettingsService.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Sep 30, 2022
server/src/main/java/org/elasticsearch/reservedstate/service/FileSettingsService.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Sep 30, 2022
server/src/main/java/org/elasticsearch/reservedstate/service/FileSettingsService.java
Outdated
Show resolved
Hide resolved
added 3 commits
October 3, 2022 10:36
…search into operator/retry_register
thecoop
approved these changes
Oct 3, 2022
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering a file for watching can fail because the OS (Linux) may not have enough inotify keys to hand out. Before failing to start the watch service, we should retry few times to ensure the OS situation isn't a temporary state.
Relates to #89500
If this enhancement doesn't resolve #89500, we will need to make a different fix to our gradle test framework that enables testing of the new file settings service. Porting to 8.5.1 because we have CI failures there too.