Replace ClusterInfo#dataPath key#90515
Merged
idegtiarenko merged 2 commits intoelastic:mainfrom Oct 4, 2022
Merged
Conversation
Replace ClusterInfo#dataPath ShardRouting key with a smaller one that only have a necessary information. Previously dataPath could not be found in case if any shard info changes before ClusterInfo is refreshed
idegtiarenko
commented
Sep 29, 2022
| @@ -65,14 +67,14 @@ public ClusterInfo( | |||
| Map<String, DiskUsage> mostAvailableSpaceUsage, | |||
| Map<String, Long> shardSizes, | |||
Contributor
Author
There was a problem hiding this comment.
I wonder if it is worth to also replace this map key with a record instead of relying on ClusterInfo#shardIdentifierFromRouting(ShardRouting shardRouting)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ClusterInfo#dataPath ShardRouting key with a smaller one that only have a necessary information. Previously dataPath could not be found in case if any shard info changes before ClusterInfo is refreshed
Closes: #90109