Merged
Conversation
Contributor
There was a problem hiding this comment.
no need for volatile here no?
Member
Author
There was a problem hiding this comment.
You're right, I will remove that.
Contributor
|
I left a minor comment LGTM otherwise |
51466c4 to
8dd3452
Compare
This allows specifying the path an index will be at.
`index.data_path` is specified in the settings when creating an index,
and can not be dynamically changed.
An example request would look like:
POST /myindex
{
"settings": {
"number_of_shards": 2,
"data_path": "/tmp/myindex"
}
}
And would put data in /tmp/myindex/0/index/0 and /tmp/myindex/0/index/1
Since this can be used to write data to arbitrary locations on disk, it
requires enabling the `node.enable_custom_paths` setting in
elasticsearch.yml on all nodes.
Relates to elastic#8976
8dd3452 to
a4e2230
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is a fixed version of #8819, which had a lot of test failures and was subsequently reverted. The failures were partially related to ddf83a9, which was not properly injecting the right settings into the MockFSIndexStore. It also fixes some state file overwriting that occurred on Windows by making the custom path logic less invasive)
This allows specifying the path an index will be at.
index.data_pathis specified in the settings when creating an index,and can not be dynamically changed.
An example request would look like:
And would put data in
/tmp/myindex/0/index/0and/tmp/myindex/0/index/1.Note that index and shard state is still written to the node's
path.datadirectory, because we use this for internal accounting (though this may
change in a subsequent shadow-replica-related PR)
Since this can be used to write data to arbitrary locations on disk, it
requires enabling the
node.enable_custom_pathssetting inelasticsearch.yml on all nodes.
Relates to #8976