Optimize unchanged metadata handling in PersistedClusterStateService#90164
Merged
original-brownbear merged 1 commit intoelastic:mainfrom Sep 20, 2022
original-brownbear:optimize-metadata-unchanged
Merged
Optimize unchanged metadata handling in PersistedClusterStateService#90164original-brownbear merged 1 commit intoelastic:mainfrom original-brownbear:optimize-metadata-unchanged
original-brownbear merged 1 commit intoelastic:mainfrom
original-brownbear:optimize-metadata-unchanged
Conversation
With #90101 both follower and leader nodes will get instance equality on the metadata on non-metadata changes here reliably. We can leverage that and skip the expensive loop over all indices in this method on instance equality.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
Thanks David! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #90101 both follower and leader nodes will get instance equality on the metadata on non-metadata changes here reliably. We can leverage that and skip the expensive loop over all indices in this method on instance equality.
relates #77466